Alon Bar-Lev has posted comments on this change.

Change subject: tools: notifier: filter messages based on severity
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/38442/2/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java
File 
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/filter/FirstMatchSimpleFilter.java:

Line 22:             "\\s*" +
Line 23:             "((?<include>include)|(?<exclude>exclude))" +
Line 24:             ":" +
Line 25:             "((?<anymsg>\\*)|(?<message>\\w+))" +
Line 26:             "(?>" +
> what is the meaning of '>' I think can be dropped.
ok, just seen your comment, I am almost sure it is not required.
Line 27:                 ":" +
Line 28:                 "((?<severity>\\*|ALERT|ERROR|WARNING|NORMAL))" +
Line 29:             ")?" +
Line 30:             "(?<recipient>" +


-- 
To view, visit https://gerrit.ovirt.org/38442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia8abc34d56f1ede2fb51daf71dee293d08f198a3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Mooli Tayer <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to