Einav Cohen has posted comments on this change. Change subject: userportal, webadmin: convert remaining widgets to PatternFly tooltips ......................................................................
Patch Set 8: Greg, here are a few issues that I have noticed; some may not be related to your patches at all, others may be issues that you are already aware of and are on your TODO list - let me know what you think: 1. There are no tool-tips on cropped grid-column text headers [https://raw.githubusercontent.com/eco-public/clipboard/master/out-23.ogv] or on icon column headers (I don't have a screen-cast for that). For grid-column text headers: when cropped, it would be nice to have them with the "..." suffix, just like text-cells in the grids' body (we never had the ellipsis feature for column text *headers*, I think). 2. Grid column-sorting behavior is completely off: When clicking the column header, nothing happens. Re-size the column - the sorting-triangle icon suddenly appears (on-mouse-leave). Another click on the column header - nothing happens. Re-size the column again - sorting-triangle icon suddenly flips (allegedly indicating that sorting was reversed). Throughout this entire scenario - *no sorting is actually being performed* [https://raw.githubusercontent.com/eco-public/clipboard/master/out-24.ogv]. 3. When hovering over the grid column headers from left to right - mouse cursor seems OK. However, when hovering over the grid column headers from right to left - mouse cursor gets "stuck" on the column-resize icon (pointing out that there are no mouse-clicks involved in this scenario - only hovering) [https://raw.githubusercontent.com/eco-public/clipboard/master/out-25.ogv]. 4. [Most likely not related to your patch, but mentioning anyway just in case it somehow is] Widths of grid-columns in the Disks main-tab are evenly distributed, which looks strange [http://i.imgur.com/yVvSqb5.png]. 5. [May be related to 4 / may not be related to your patches] Re-sizing of the Disks' grid-columns is behaving strange (re-sizing one column unexpectedly affects other columns as well) [https://raw.githubusercontent.com/eco-public/clipboard/master/out-26.ogv]. 6. Tool-tips for the "Attached to" column in the Disks grid are "regular" tool-tips (i.e. tool-tips that show the full cell-text when it is cropped), which is OK for Disks that are attached to only one VM/Template. But in case a Disk is attached to more than one VM and the grid-cell shows e.g. "2 VMs", need a tool-tip that (a) will contain the actual names of the VMs (e.g. "VM1, VM2") and (b) will be displayed upon hovering always (and not only when text is cropped) [same image as 4]. Thanks. -- To view, visit https://gerrit.ovirt.org/38360 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic247147c091f4fa6e6c09689c85b6901c74f11f3 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
