Alona Kaplan has posted comments on this change.

Change subject: engine: add 'vds_maintenance_reason_required' column to 
vds_group
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/38297/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSGroup.java:

Line 82: vdsMaintenanceReasonRequired
> i think the 'vds' prefix isn't needed.
Done


https://gerrit.ovirt.org/#/c/38297/3/packaging/dbscripts/upgrade/03_06_0950_vds_optional_reason.sql
File packaging/dbscripts/upgrade/03_06_0950_vds_optional_reason.sql:

Line 1: select fn_db_add_column('vds_groups', 
'vds_maintenance_reason_required', 'boolean not null default false');
> as stated in previous comment either maintenance_reason_required or host_ma
Done


-- 
To view, visit https://gerrit.ovirt.org/38297
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f3174acf5341a27e8c9d54a393bc93c75a54f7b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to