Hello Fred Rolland,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/38488

to review the following change.

Change subject: webadmin: New VM dialog - advanced options
......................................................................

webadmin: New VM dialog - advanced options

When you open the new/edit any VM based dialog, and click "show
advanced options" and close the dialog, this setting will be persisted
and on next open of the same dialog, you don't need to click it.

Restoring this feature after refactoring.

Change-Id: I61677816c304c0506d10ec1e297a5d42fcd831e6
Signed-off-by: Fred Rolland <[email protected]>
---
M 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/88/38488/1

diff --git 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
index 2efdf30..5953988 100644
--- 
a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
+++ 
b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/VmBaseListModel.java
@@ -281,7 +281,6 @@
             VmType vmtype,
             SystemTreeItemModel systemTreeItemModel,
             List<UICommand> uiCommands) {
-        setWindow(model);
         
model.setTitle(ConstantsManager.getInstance().getConstants().newVmTitle());
         model.setHelpTag(HelpTag.new_vm);
         model.setHashName("new_vm"); //$NON-NLS-1$


-- 
To view, visit https://gerrit.ovirt.org/38488
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61677816c304c0506d10ec1e297a5d42fcd831e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <[email protected]>
Gerrit-Reviewer: Fred Rolland <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to