Alon Bar-Lev has posted comments on this change. Change subject: engine: add SessionDataContainer.getSessionIdBySeqId method ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38380/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java: Line 111: } Line 112: Line 113: public String getSessionIdBySeqId(long sessionSequenceId) { Line 114: return findFirstSessionByData(sessionSequenceId, ENGINE_SESSION_SEQ_ID); Line 115: } I think simpler will be adding the session id into the session entry when constructing. then just loop the sessionInfoMap.values() not sure that one time called function findFirstSessionByData is needed in this case, and if yes, it can be squashed here. not critical Line 116: Line 117: private String findFirstSessionByData(Object keyData, String key) { Line 118: if (keyData == null || key == null) { Line 119: return null; -- To view, visit https://gerrit.ovirt.org/38380 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4069c594a553c45869bf45cfa680da4c1b65dabb Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
