Alon Bar-Lev has posted comments on this change. Change subject: engine: add TerminateSession command ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38382/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/TerminateSessionCommand.java: Line 53: protected void executeCommand() { Line 54: setReturnValue( Line 55: getBackend().logoff( Line 56: new VdcActionParametersBase(terminatedSessionId))); Line 57: } I am unsure about the need for canDoAction(), why not just execute, worse case you get failure? I also never liked the set of object state between the canDoAction and execute.... but this is another discussion :( Line 58: Line 59: @Override Line 60: protected boolean isUserAuthorizedToRunAction() { Line 61: return isSystemSuperUserPredicate.eval(getCurrentUser().getId()); -- To view, visit https://gerrit.ovirt.org/38382 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebdc71abbd51d2eb01b2b3d9c877626d57d68d23 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
