Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Corrected VDS commands as per latest VDSM verbs ......................................................................
Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/38498/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1655: return new GlusterVolumeSnapshotInfoReturnForXmlRpc(clusterId, response); Line 1656: } Line 1657: Line 1658: @Override Line 1659: public GlusterVolumeSnapshotConfigReturnForXmlRpc glusterVolumeSnapshotConfigGet(Guid clusterId, String volumeName) { > Is the parameter volumeName not used? Yes with new changes its not used, as we always call this for whole cluster. May be I would remove this. Line 1660: JsonRpcRequest request = Line 1661: new RequestBuilder("GlusterSnapshot.configList").build(); Line 1662: Map<String, Object> response = new FutureMap(this.client, request).withIgnoreResponseKey(); Line 1663: return new GlusterVolumeSnapshotConfigReturnForXmlRpc(clusterId, response); https://gerrit.ovirt.org/#/c/38498/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 866: Line 867: @DefaultStringValue("Failed to create snapshot for gluster volume") Line 868: String GlusterSnapshotCreateFailedException(); Line 869: Line 870: @DefaultStringValue("Gluster volume snapshot configuration failed") > Failed to configure gluster volume snapshot? done Line 871: String GlusterSnapshotConfigFailedException(); Line 872: Line 873: @DefaultStringValue("Failed to set the gluster volume snapshot configuration") Line 874: String GlusterSnapshotConfigSetFailedException(); https://gerrit.ovirt.org/#/c/38498/1/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties File frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties: Line 388: GlusterSnapshotDeactivateFailedException=Failed to de-activate gluster volume snapshot Line 389: GlusterSnapshotRestoreFailedException=Failed to restore the gluster volume snapshot Line 390: GlusterSnapshotCreateFailedException=Failed to create snapshot for gluster volume Line 391: GlusterSnapshotConfigFailedException=Gluster volume snapshot configuration failed Line 392: GlusterSnapshotConfigSetFailedException="Failed to set the gluster volume snapshot configuration" > quotes not required here oh sorry! due to copy paste. will correct -- To view, visit https://gerrit.ovirt.org/38498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief9bcdf7d05f5d4e0bb54a3163ec27c57ccf81e0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Darshan N <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
