Martin Peřina has posted comments on this change. Change subject: engine: refactor PermissionsCommandBase.isSystemSuperUser method out ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/38379/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsSystemSuperUserPredicate.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsSystemSuperUserPredicate.java: > shouldn't adding such be accompanies with wide refactoring of all cases in I have a note to look for other usage of this. If I found any I will prepare patches Line 1: package org.ovirt.engine.core.bll; Line 2: Line 3: import java.util.Objects; Line 4: -- To view, visit https://gerrit.ovirt.org/38379 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b87b1709a3fc80fdcd090a0079189cef4a6ab62 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
