Sahina Bose has posted comments on this change. Change subject: engine : VDS command for creating geo-rep session ......................................................................
Patch Set 21: (5 comments) https://gerrit.ovirt.org/#/c/29833/21/backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties: Line 374: GlusterServiceActionNotSupported=Gluster service action not supported Line 375: GlusterVolumeStatusAllFailedException=Failed to get gluster tasks list Line 376: GlusterVolumeRebalanceStatusFailedException=Failed to get gluster volume rebalance status Line 377: GlusterVolumeGeoRepStatusFailedException=Failed to get status information of geo-replication session(s) on gluster volume Line 378: GlusterGeoRepPublicKeyFileCreateFailed=Failed to create public key file. Failed to create gluster hosts public key file? Line 379: GlusterGeoRepPublicKeyFileNotFound=Public key file does not exist. Line 380: GlusterGeoRepUserHomeDirectoryNotFound=Geo-replication user does not have home directory. Line 381: GlusterGeoRepUserNotFound=Geo-replication user does not exist. Line 382: GlusterGeoRepPublicKeyWriteFailed=Failed to write public key. https://gerrit.ovirt.org/#/c/29833/21/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 1200: @Override Line 1201: public StatusOnlyReturnForXmlRpc glusterWriteGeoRepPubKeys(String userName, String geoRepPubKeys) { Line 1202: JsonRpcRequest request = Line 1203: new RequestBuilder("Gluster.writeGeoRepPubKeys").withOptionalParameter("userName", userName) Line 1204: .withParameter("geoRepPubKeys", geoRepPubKeys).build(); Shouldn't optional parameters be at the end? Same comment in below methods as well Line 1205: Map<String, Object> response = new FutureMap(this.client, request); Line 1206: return new StatusOnlyReturnForXmlRpc(response); Line 1207: } Line 1208: Line 1212: String groupName) { Line 1213: JsonRpcRequest request = Line 1214: new RequestBuilder("GlusterVolume.setupGeoRepMountBroker").withOptionalParameter("userName", userName) Line 1215: .withParameter("remoteVolumeName", remoteVolumeName) Line 1216: .withParameter("groupName", groupName).build(); is groupName a required/optional parameter? Line 1217: Map<String, Object> response = new FutureMap(this.client, request); Line 1218: return new StatusOnlyReturnForXmlRpc(response); Line 1219: } Line 1220: https://gerrit.ovirt.org/#/c/29833/21/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java: Line 327: GlusterHostsPubKeyReturnForXmlRpc glusterGetGeoRepPubKeys(); Line 328: Line 329: StatusOnlyReturnForXmlRpc glusterWriteGeoRepPubKeys(String userName, String geoRepPubKeys); Line 330: Line 331: StatusOnlyReturnForXmlRpc glusterSetupGeoRepMountBroker(String userName, String remoteVolumeName, String groupName); Put optional parameters as the last arguments Line 332: Line 333: StatusOnlyReturnForXmlRpc glusterVolumeGeoRepSessionCreate(String volumeName, String remoteHost, String remoteVolumeName, String userName, Boolean force); Line 334: Line 335: GlusterVolumeGeoRepStatusForXmlRpc glusterVolumeGeoRepSessionList(); https://gerrit.ovirt.org/#/c/29833/21/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java: Line 732: Line 733: @DefaultStringValue("Geo-replication user does not exist.") Line 734: String GlusterGeoRepUserNotFound(); Line 735: Line 736: @DefaultStringValue("Failed to write public key.") Failed to write gluster host public key? Line 737: String GlusterGeoRepPublicKeyWriteFailed(); Line 738: Line 739: @DefaultStringValue("Failed to set geo rep mount broker option.") Line 740: String GlusterGeoRepExecuteMountBrokerOptFailed(); -- To view, visit https://gerrit.ovirt.org/29833 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8164990c5c377481f1b1244ae548f7eca3066b6 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
