Moti Asayag has uploaded a new change for review. Change subject: engine: The name argument is ignored and removed ......................................................................
engine: The name argument is ignored and removed There is no consideration of the name argument which is passed to the CacheWrapper. Change-Id: I9d25fd8c6afbd8e508f2d696e0edbebd2aa0aac4 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java 3 files changed, 5 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/38514/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java index e1a7765..d8898f3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CacheProviderFactory.java @@ -1,7 +1,7 @@ package org.ovirt.engine.core.bll.tasks; public class CacheProviderFactory { - public static <K, V> CacheWrapper<K, V> getCacheWrapper(String name) { + public static <K, V> CacheWrapper<K, V> getCacheWrapper() { return new MapWrapperImpl<K, V>(); } } diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java index a5fefff..b09cbb3 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandContextsCacheImpl.java @@ -10,7 +10,6 @@ public class CommandContextsCacheImpl implements CommandContextsCache { - private static final String COMMAND_CONTEXT_MAP_NAME = "commandContextMap"; private final CommandsCache commandsCache; private CacheWrapper<Guid, CommandContext> contextsMap; private volatile boolean cacheInitialized; @@ -18,7 +17,7 @@ public CommandContextsCacheImpl(final CommandsCache commandsCache) { this.commandsCache = commandsCache; - contextsMap = CacheProviderFactory.<Guid, CommandContext> getCacheWrapper(COMMAND_CONTEXT_MAP_NAME); + contextsMap = CacheProviderFactory.<Guid, CommandContext> getCacheWrapper(); } private void initializeCache() { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java index 0b91f0e..be4fa00 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/tasks/CommandsCacheImpl.java @@ -3,6 +3,8 @@ import java.util.List; import java.util.Set; +import javax.transaction.Transaction; + import org.ovirt.engine.core.common.businessentities.CommandEntity; import org.ovirt.engine.core.compat.CommandStatus; import org.ovirt.engine.core.compat.DateTime; @@ -10,17 +12,14 @@ import org.ovirt.engine.core.dal.dbbroker.DbFacade; import org.ovirt.engine.core.utils.transaction.TransactionSupport; -import javax.transaction.Transaction; - public class CommandsCacheImpl implements CommandsCache { - private static final String COMMAND_MAP_NAME = "commandMap"; CacheWrapper<Guid, CommandEntity> commandMap; private volatile boolean cacheInitialized; private Object LOCK = new Object(); public CommandsCacheImpl() { - commandMap = CacheProviderFactory.<Guid, CommandEntity> getCacheWrapper(COMMAND_MAP_NAME); + commandMap = CacheProviderFactory.<Guid, CommandEntity> getCacheWrapper(); } private void initializeCache() { -- To view, visit https://gerrit.ovirt.org/38514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9d25fd8c6afbd8e508f2d696e0edbebd2aa0aac4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
