Piotr Kliczewski has posted comments on this change. Change subject: engine: Replace deprecated access to ResourceManager ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38524/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/transport/ProtocolDetector.java: Line 69: /** Line 70: * Stops {@code VdsManager} for a host. Line 71: */ Line 72: public void stopConnection() { Line 73: resourceManager.RemoveVds(this.vds.getId()); > i'd rather not to. i'm using 'this' only where ambiguity exists. else, it i This is my first time hearing opinion about 'this'. It is up to you how you want to refer to instance fields. It makes it less error prone. Line 74: } Line 75: Line 76: /** Line 77: * Fall back the protocol and attempts the connection {@link ProtocolDetector#attemptConnection()}. -- To view, visit https://gerrit.ovirt.org/38524 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie78fff7c5be5998bd9c769cbefa99317ac590b89 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
