Frank Kobzik has posted comments on this change. Change subject: core: Fix splitting logic for ip addresses ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/36946/3/packaging/dbscripts/create_functions.sql File packaging/dbscripts/create_functions.sql: Line 893: CREATE OR REPLACE FUNCTION fn_get_comparable_ip_list(text) RETURNS inet[] IMMUTABLE STRICT Line 894: AS $procedure$ Line 895: BEGIN Line 896: CASE Line 897: WHEN ($1 IS NULL) OR ($1 ~ E'^\\s*$') THEN > Okay, I wouldn't trust my memory/understanding of it anyway - if it works o :) I've just tested with postgres from 3.4 (postgres 8.4.20) and the function from this PS works fine. The version with single '\' was broken on 3.4 in case of multiple ips, so this bug is even in 3.4 (but I suppose it didn't have much attention since there was no column sorting back then...). I'll rebase and repush and if you're ok with it, I'll remind Eli about it. Thanks! Line 898: RETURN NULL; Line 899: ELSE Line 900: RETURN regexp_split_to_array(trim(both from $1), E'\\s+')::inet[]; Line 901: END CASE; -- To view, visit https://gerrit.ovirt.org/36946 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6923e1d99185e9aca69036edda00293ed1718b92 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
