Alon Bar-Lev has posted comments on this change. Change subject: aaa: Rework webadmin login sequence ......................................................................
Patch Set 5: (5 comments) https://gerrit.ovirt.org/#/c/38212/5/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionMgmtFilter.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/filters/SessionMgmtFilter.java: Line 27: if (StringUtils.isEmpty(engineSessionId)) { Line 28: engineSessionId = (String) ((HttpServletRequest) request).getSession(true).getAttribute(SessionConstants.HTTP_SESSION_ENGINE_SESSION_ID_KEY); Line 29: } Line 30: if (engineSessionId != null) { Line 31: ((HttpServletResponse) response).addHeader("OVIRT-SSO-TOKEN", engineSessionId); I am not sure I follow, maybe this entire filter can be removed and we can return the sso token always in request and response? Line 32: } Line 33: chain.doFilter(request, response); Line 34: } Line 35: https://gerrit.ovirt.org/#/c/38212/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java: Line 792 Line 793 Line 794 Line 795 Line 796 part of this patch? Line 802 Line 803 Line 804 Line 805 Line 806 part of this patch? https://gerrit.ovirt.org/#/c/38212/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/communication/VdcOperationManager.java: Line 33: Line 34: /** Line 35: * Flag that tells us if we are logged in or not. Line 36: */ Line 37: private boolean loggedIn = true; what does it mean? why do we need this? how come we are not logged in? :) Line 38: Line 39: /** Line 40: * Constructor. Line 41: * @param operationProcessor the operation processor. https://gerrit.ovirt.org/#/c/38212/5/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/GenericApiGWTServiceImpl.java: Line 211: HttpSession session = request.getSession(); Line 212: Object value = session.getAttribute(UI_PREFIX + key); Line 213: if (value == null) { Line 214: value = session.getAttribute(key); Line 215: } hmm... this is also not directly related to aaa, right? can be pushed regardless. Line 216: String result = null; Line 217: if (value instanceof String) { Line 218: result = (String)value; Line 219: } else if (value != null) { -- To view, visit https://gerrit.ovirt.org/38212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76ecd389f4938e294d1b3d82f5e1a42eb60d9a20 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
