Omer Frenkel has posted comments on this change. Change subject: backend: Implementation support for GuestOsInfo and Timezone reporting ......................................................................
Patch Set 14: (5 comments) https://gerrit.ovirt.org/#/c/29322/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestOsArchitectureType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestOsArchitectureType.java: Line 7: undefined(0), Line 8: x86_64(1), Line 9: ppc64(2), Line 10: ppc(3), Line 11: x86(4); in OsInfo we use the ArchitectureType which has only x86_64 and ppc64, isnt it good enough? Line 12: Line 13: Line 14: private int value; Line 15: private static final HashMap<Integer, GuestOsArchitectureType> valueToArchitecture = https://gerrit.ovirt.org/#/c/29322/14/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java: Line 732: public void setGuestAgentStatus(GuestAgentStatus status) { Line 733: vmDynamic.setGuestAgentStatus(status); Line 734: } Line 735: Line 736: public int getTimezoneOffset() { what is the difference between this and utc-diff in this entity? Line 737: return vmDynamic.getTimezoneOffset(); Line 738: } Line 739: Line 740: public void setTimezoneOffset(int timezoneOffset) { https://gerrit.ovirt.org/#/c/29322/14/backend/manager/modules/dal/src/test/resources/fixtures.xml File backend/manager/modules/dal/src/test/resources/fixtures.xml: Line 3792 Line 3793 Line 3794 Line 3795 Line 3796 why do you remove this? https://gerrit.ovirt.org/#/c/29322/14/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 381: if (xmlRpcStruct.containsKey(VdsProperties.GUEST_CPU_COUNT)) { Line 382: vm.setGuestCpuCount(AssignIntValue(xmlRpcStruct, VdsProperties.GUEST_CPU_COUNT)); Line 383: } Line 384: Line 385: // Guest OS Info maybe extract this to a method that handles guest os info ? Line 386: if(xmlRpcStruct.containsKey(VdsProperties.GUEST_OS_INFO)) { Line 387: Map<String, Object> guestOsInfoStruct = (Map<String, Object>) xmlRpcStruct.get(VdsProperties.GUEST_OS_INFO); Line 388: vm.setGuestOsArch(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_ARCH)); Line 389: vm.setGuestOsCodename(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_CODENAME)); Line 382: vm.setGuestCpuCount(AssignIntValue(xmlRpcStruct, VdsProperties.GUEST_CPU_COUNT)); Line 383: } Line 384: Line 385: // Guest OS Info Line 386: if(xmlRpcStruct.containsKey(VdsProperties.GUEST_OS_INFO)) { please use the project formatter (missing space after 'if') Line 387: Map<String, Object> guestOsInfoStruct = (Map<String, Object>) xmlRpcStruct.get(VdsProperties.GUEST_OS_INFO); Line 388: vm.setGuestOsArch(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_ARCH)); Line 389: vm.setGuestOsCodename(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_CODENAME)); Line 390: vm.setGuestOsDistribution(AssignStringValue(guestOsInfoStruct, VdsProperties.GUEST_OS_INFO_DISTRIBUTION)); -- To view, visit https://gerrit.ovirt.org/29322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc1e54d39706601c0faf9d76785f1257ee20755b Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
