Alexander Wels has posted comments on this change. Change subject: frontend: refactoring: Introduce NameRenderer utility ......................................................................
Patch Set 1: Verified+1 (1 comment) One minor nitpick about some cleanup that is not related to the subject of the patch. Other than that great patch. If you can separate that one file into a separate patch, I can merge them both. https://gerrit.ovirt.org/#/c/38550/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java: Line 20: >> So these changes do not appear to be related to the subject of the patch. Its still good cleanup, but maybe should be in a separate patch? -- To view, visit https://gerrit.ovirt.org/38550 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c87be39de7663bf135bcc538b3b5a3106bb5c3a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
