Arik Hadas has posted comments on this change. Change subject: backend: Make several entities implement Nameable ......................................................................
Patch Set 3: (6 comments) https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/MacPool.java: Line 45: public void setId(Guid id) { Line 46: this.id = id; Line 47: } Line 48: Line 49: public String getName() { missing @Override Line 50: return name; Line 51: } Line 52: Line 53: public void setName(String name) { https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Role.java: Line 79: public boolean isReadonly() { Line 80: return this.readOnly; Line 81: } Line 82: Line 83: public String getName() { missing @Override Line 84: return this.name; Line 85: } Line 86: Line 87: @Override https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileStats.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileStats.java: Line 11: Line 12: private String name; Line 13: private List<StatsInfo> profileStats; Line 14: Line 15: public String getName() { missing @Override Line 16: return name; Line 17: } Line 18: Line 19: public void setIdentity(String identity) { https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosBase.java: Line 72: public void setId(Guid id) { Line 73: this.id = id; Line 74: } Line 75: Line 76: public String getName() { missing @Override Line 77: return name; Line 78: } Line 79: Line 80: public void setName(String name) { https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/ClusterPolicy.java: Line 74: public void setId(Guid id) { Line 75: this.id = id; Line 76: } Line 77: Line 78: public String getName() { missing @Override Line 79: return name; Line 80: } Line 81: Line 82: public void setName(String name) { https://gerrit.ovirt.org/#/c/38549/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/scheduling/PolicyUnit.java: Line 62: public void setId(Guid id) { Line 63: this.id = id; Line 64: } Line 65: Line 66: public String getName() { missing @Override Line 67: return name; Line 68: } Line 69: Line 70: public void setName(String name) { -- To view, visit https://gerrit.ovirt.org/38549 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icaa0e531e88f041f28645c6892f651d93a5aed18 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
