Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: AbstractTooltipCell fixup ......................................................................
userportal, webadmin: AbstractTooltipCell fixup (Patch 4n of 12) Forgot to mark methods as final. Forgot to call super() from onBrowserEvent. Fixed. Change-Id: Id31767ca21fdfc4f4c94d88870068fbda7b834d3 Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/20/38620/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java index 65cb867..3d2a40d 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/cell/AbstractTooltipCell.java @@ -56,7 +56,7 @@ * @see com.google.gwt.cell.client.AbstractCell#onBrowserEvent(com.google.gwt.cell.client.Cell.Context, com.google.gwt.dom.client.Element, java.lang.Object, com.google.gwt.dom.client.NativeEvent, com.google.gwt.cell.client.ValueUpdater) */ @Override - public void onBrowserEvent(Context context, Element parent, C value, NativeEvent event, ValueUpdater<C> valueUpdater) { + public final void onBrowserEvent(Context context, Element parent, C value, NativeEvent event, ValueUpdater<C> valueUpdater) { onBrowserEvent(context, parent, value, null, event, valueUpdater); } @@ -84,6 +84,8 @@ if (BrowserEvents.MOUSEDOWN.equals(event.getType())) { TooltipMixin.hideAllTooltips(); } + + super.onBrowserEvent(context, parent, value, event, valueUpdater); } /** @@ -100,7 +102,7 @@ * * @see com.google.gwt.cell.client.AbstractCell#render(com.google.gwt.cell.client.Cell.Context, java.lang.Object, com.google.gwt.safehtml.shared.SafeHtmlBuilder) */ - public void render(Context context, C value, SafeHtmlBuilder sb) { + public final void render(Context context, C value, SafeHtmlBuilder sb) { String id = ElementIdUtils.createTableCellElementId(getElementIdPrefix(), getColumnId(), context); render(context, value, sb, id); } -- To view, visit https://gerrit.ovirt.org/38620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id31767ca21fdfc4f4c94d88870068fbda7b834d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
