Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn ......................................................................
userportal, webadmin: rename AbstractLinkColumnWithTooltip -> AbstractLinkColumn (Patch 4g of 12) No logic changes. Just a rename. Change-Id: I8f2322629b86fb4610a49d24741a228f424d3c59 Signed-off-by: Greg Sheremeta <[email protected]> --- R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java 3 files changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/12/38612/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumn.java similarity index 62% rename from frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java rename to frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumn.java index 0a4703c..1b56c16 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumnWithTooltip.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/AbstractLinkColumn.java @@ -11,17 +11,17 @@ * @param <T> * the row type. */ -public abstract class AbstractLinkColumnWithTooltip<T> extends AbstractTextColumn<T> { +public abstract class AbstractLinkColumn<T> extends AbstractTextColumn<T> { - public AbstractLinkColumnWithTooltip() { + public AbstractLinkColumn() { this(null); } - public AbstractLinkColumnWithTooltip(FieldUpdater<T, String> fieldUpdater) { + public AbstractLinkColumn(FieldUpdater<T, String> fieldUpdater) { this(TextCell.UNLIMITED_LENGTH, fieldUpdater); } - public AbstractLinkColumnWithTooltip(int maxTextLength, FieldUpdater<T, String> fieldUpdater) { + public AbstractLinkColumn(int maxTextLength, FieldUpdater<T, String> fieldUpdater) { super(new LinkCell(maxTextLength)); setFieldUpdater(fieldUpdater); } diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java index e9e21f8..4ce57c2 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabNetworkView.java @@ -15,7 +15,7 @@ import org.ovirt.engine.core.searchbackend.NetworkConditionFieldAutoCompleter; import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.uicommon.model.MainModelProvider; -import org.ovirt.engine.ui.common.widget.table.column.AbstractLinkColumnWithTooltip; +import org.ovirt.engine.ui.common.widget.table.column.AbstractLinkColumn; import org.ovirt.engine.ui.common.widget.table.column.AbstractSafeHtmlWithSafeHtmlTooltipColumn; import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn; import org.ovirt.engine.ui.uicommonweb.UICommand; @@ -39,7 +39,7 @@ private final SafeHtml vmImage; private final SafeHtml emptyImage; - private AbstractLinkColumnWithTooltip<NetworkView> providerColumn; + private AbstractLinkColumn<NetworkView> providerColumn; @Inject public MainTabNetworkView(MainModelProvider<NetworkView, NetworkListModel> modelProvider, @@ -138,7 +138,7 @@ labelColumn.makeSortable(NetworkConditionFieldAutoCompleter.LABEL); getTable().addColumn(labelColumn, constants.networkLabelNetworksTab(), "200px"); //$NON-NLS-1$ - providerColumn = new AbstractLinkColumnWithTooltip<NetworkView>() { + providerColumn = new AbstractLinkColumn<NetworkView>() { @Override public String getValue(NetworkView object) { return object.getProvidedBy() == null ? "" : object.getProviderName(); //$NON-NLS-1$ diff --git a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java index 00bffb6..25f1813 100644 --- a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java +++ b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/provider/SubTabProviderNetworkView.java @@ -6,7 +6,7 @@ import org.ovirt.engine.core.common.businessentities.network.NetworkView; import org.ovirt.engine.ui.common.idhandler.ElementIdHandler; import org.ovirt.engine.ui.common.uicommon.model.SearchableDetailModelProvider; -import org.ovirt.engine.ui.common.widget.table.column.AbstractLinkColumnWithTooltip; +import org.ovirt.engine.ui.common.widget.table.column.AbstractLinkColumn; import org.ovirt.engine.ui.common.widget.table.column.AbstractTextColumn; import org.ovirt.engine.ui.uicommonweb.UICommand; import org.ovirt.engine.ui.uicommonweb.models.providers.ProviderListModel; @@ -29,7 +29,7 @@ private final ApplicationConstants constants; - private AbstractLinkColumnWithTooltip<NetworkView> nameColumn; + private AbstractLinkColumn<NetworkView> nameColumn; @Inject public SubTabProviderNetworkView(SearchableDetailModelProvider<NetworkView, ProviderListModel, ProviderNetworkListModel> modelProvider, @@ -49,7 +49,7 @@ void initTable() { getTable().enableColumnResizing(); - nameColumn = new AbstractLinkColumnWithTooltip<NetworkView>() { + nameColumn = new AbstractLinkColumn<NetworkView>() { @Override public String getValue(NetworkView object) { return object.getName(); -- To view, visit https://gerrit.ovirt.org/38612 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8f2322629b86fb4610a49d24741a228f424d3c59 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
