Juan Hernandez has posted comments on this change. Change subject: restapi: provide management network link upon cluster retrieval ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/38627/1/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java: Line 159: getOptionalEntity(org.ovirt.engine.core.common.businessentities.network.Network.class, Line 160: VdcQueryType.GetManagementNetwork, Line 161: new IdQueryParameters(clusterId), Line 162: clusterId.toString(), Line 163: false); > I put that in doPopulate method with intention that isn't being run unless Yes, it is correct, that and the fact that usually there are only a few clusters make my comment mostly irrelevant. I'm merging. Line 164: if (network != null) { Line 165: final Network managementNetwork = new org.ovirt.engine.api.model.Network(); Line 166: managementNetwork.setCluster(cluster); Line 167: managementNetwork.setId(network.getId().toString()); -- To view, visit https://gerrit.ovirt.org/38627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad3403dc1ece3d2973054f29f4c7dd2049d39878 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
