Amit Aviram has posted comments on this change. Change subject: webadmin: Disabling unsupported storage types when adding a domain. ......................................................................
Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/38544/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/GlusterStorageModel.java: Line 36: } Line 37: Line 38: @Override Line 39: public boolean isSupportedInVersion(Version dcVersion) { Line 40: return (Boolean) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.GlusterFsStorageEnabled , dcVersion.toString()); > Consider to separate into two lines. The length of this line is 152 (should Thanks, Done- will use the formatter. Line 41: } https://gerrit.ovirt.org/#/c/38544/5/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java: Line 129: } Line 130: Line 131: @Override Line 132: public boolean isSupportedInVersion(Version dcVersion) { Line 133: return (Boolean) AsyncDataProvider.getInstance().getConfigValuePreConverted(ConfigurationValues.PosixStorageEnabled, dcVersion.toString()); > Consider to separate into two lines. The length of this line is 147 (should Thanks, Done- will use the formatter. Line 134: } -- To view, visit https://gerrit.ovirt.org/38544 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5fcc131454e0722fbf8d6e84607a71381e1d04fb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
