Vojtech Szocs has posted comments on this change.
Change subject: webadmin,userportal: Progress indicator during login
......................................................................
Patch Set 1:
Verified in production (web) mode for all possible scenarios:
* user not logged-in yet, login form is shown, progress starts after hitting
Enter/Login, and lasts until main section is reached
* user is already logged-in but doesn't request specific place in WebAdmin URL,
login form is shown and filled, progress starts and lasts until main section is
reached
* user is already logged-in and requests specific place in WebAdmin URL (e.g.
#vms), login form is skipped (we're going right into the given place), progress
starts and lasts until main section is reached
In future, we might consider having separate progress indicator for main
section, e.g. "Loading" box in top center location. For now, there is only one
kind of progress indicator - special ('wait') mouse cursor for login section.
(!) Important Note (!)
In GWTP 0.6, there is a serious bug in
PlaceManagerImpl.getCurrentPlaceRequest() which can cause
ArrayIndexOutOfBoundsException to escape from try/catch block in production
mode (will NOT happen in development mode). This bug is fixed in GWTP 0.7. In
the meantime, the patch overrides this method in ApplicationPlaceManager to fix
this bug, until it gets fixed in GWTP core (PlaceManagerImpl).
In general, using try/catch blocks when handling array-based structures (e.g.
catching ArrayIndexOutOfBoundsException when operating ArrayList) is NOT safe
with GWT (see above why). In this context, using if statements should be always
preferred to using try/catch blocks.
--
To view, visit http://gerrit.ovirt.org/7720
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecc4892e0848bfedf63a974b94acf2564241a0c7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
