Alon Bar-Lev has posted comments on this change. Change subject: core, userportal, webadmin: VirtIO console access key management ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/35810/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetSshPublicKeyCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetSshPublicKeyCommand.java: Line 13: Line 14: import java.util.Collections; Line 15: import java.util.List; Line 16: Line 17: public class SetSshPublicKeyCommand <T extends SetSshPublicKeyParameters> extends CommandBase<T> { > if we treat ssh key for user as "UserProfile" then this should be SetUserPr we should have user profile with set of properties. one of the properties can be date format the other is theme and this is a list of ssh public keys the fact that we do not have user profile so far is not that good :) a user can set his own profile. having ssh specific command is not something I would like to see. Line 18: Line 19: static final private String SSH_RSA = "ssh-rsa"; Line 20: Line 21: public SetSshPublicKeyCommand(T parameters) { -- To view, visit https://gerrit.ovirt.org/35810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id2364cafc687ba6dee2504322234067ff98dc00c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
