Allon Mureinik has posted comments on this change. Change subject: core: Moved storage related entities to the storage package ......................................................................
Patch Set 3: (1 comment) Musch better, although I think you missed a few classes - see inline https://gerrit.ovirt.org/#/c/38650/3//COMMIT_MSG Commit Message: Line 19: LunDisk Line 20: PropagateErrors Line 21: ScsiGenericIO Line 22: VolumeFormat Line 23: VolumeType You should also move the following types: * CopyVolumeType * DiskLunMap * DiskLumMapId * ImageDbOperationScope * ImageFileType * ImageOperation * ImageStorageDomainMapId * image_storage_domain_map (worth also renaming to CamelCase, probably in another patch) * ImageType * LUNs * LunStatus * LUN_storage_server_connection_map_id (worth renaming, probably in another patch) * LUN_storage_server_connection_map (worth renaming, probably in another patch) * RepoImage * StorageType The following entities are also storage-centric, although they don't relate to disks. Worth moving them too, although I'm not sure if THIS patch is the right place: * IscsiBond * NfsVersion * SANState * SpmStatus * SpmStatusResult * StorageDomain* (several classes) * StoragePool - questionable. Today, this is a DC, not 100% storage related * StorageServerConnections Line 24: Line 25: Bug-Url: https://bugzilla.redhat.com/1142762 Line 26: Change-Id: I54f304e2453ea0acd773a891e651190a3093eccc -- To view, visit https://gerrit.ovirt.org/38650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f304e2453ea0acd773a891e651190a3093eccc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
