Daniel Erez has posted comments on this change. Change subject: core: Moved storage related entities to the storage package ......................................................................
Patch Set 5: Code-Review+2 (2 comments) https://gerrit.ovirt.org/#/c/38650/5//COMMIT_MSG Commit Message: Line 30: LunDisk Line 31: LunStatus Line 32: PropagateErrors Line 33: RepoImage Line 34: ScsiGenericIOd s/ScsiGenericIOd/ScsiGenericIO Line 35: StorageType Line 36: VolumeFormat Line 37: VolumeType Line 38: https://gerrit.ovirt.org/#/c/38650/5/frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml File frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml: Line 208: <include name="common/businessentities/qos/StorageQos.java"/> Line 209: <include name="common/businessentities/qos/CpuQos.java"/> Line 210: Line 211: <!-- Storage --> Line 212: <include name="common/businessentities/storage/BaseDisk.java" /> make sure you're using spaces instead of tabs Line 213: <include name="common/businessentities/storage/CopyVolumeType.java" /> Line 214: <include name="common/businessentities/storage/Disk.java" /> Line 215: <include name="common/businessentities/storage/DiskAlignment.java" /> Line 216: <include name="common/businessentities/storage/DiskImage.java" /> -- To view, visit https://gerrit.ovirt.org/38650 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I54f304e2453ea0acd773a891e651190a3093eccc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Fred Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
