Moti Asayag has posted comments on this change. Change subject: core: DI for AuditLoggerDirector ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/33901/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java: Line 115: log.info("Power-Management: {} host '{}' failed.", getAction(), getVdsName()); Line 116: audit(AuditLogType.FENCE_OPERATION_FAILED); Line 117: } Line 118: } catch(Exception e) { Line 119: e.printStackTrace(System.err); > shit. I was debugging one test which threw exception probably in some mock the CommandBase handles logging of exceptions afair, and the esxception will be re-thrown from the finally block. so I don't see any need to handle exception here. Line 120: } finally { Line 121: if (!getSucceeded()) { Line 122: setStatus(lastStatus); Line 123: if (!wasSkippedDueToPolicy(result)) { -- To view, visit https://gerrit.ovirt.org/33901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifab56339a634234bbc51fa09719fb87b5cc69501 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
