Liron Aravot has posted comments on this change. Change subject: core: move getNewMaster to ReconstructMasterDomain ......................................................................
Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/28444/12/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java: Line 69: protected LockProperties applyLockProperties(LockProperties lockProperties) { Line 70: return lockProperties; Line 71: } Line 72: Line 73: protected StorageDomain getNewMaster() { in theory the domains status can change during the run of the reconstruct command, which will lead to unexpected results. i think that you should preserve the old behavior in which electNewMaster can be executed only once to avoid those corner cases. Line 74: if (newMaster == null) { Line 75: newMaster = electNewMaster(true, canChooseInactiveDomainAsMaster, canChooseCurrentMasterAsNewMaster); Line 76: } Line 77: return newMaster; -- To view, visit https://gerrit.ovirt.org/28444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30d342a4c5802cdfbf2c78b50dad4c797c137fe2 Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
