Greg Sheremeta has posted comments on this change. Change subject: webadmin : gwt-bootstrap DateTimeBox widget ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38729/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/GwtBootstrapDateTimePicker.java: Line 27: */ Line 28: public static final String DEFAULT_DATE_TIME_FORMAT = "mm/dd/yyyy HH:ii";//$NON-NLS-1$ Line 29: public static final String DEFAULT_TIME_FORMAT = "HH:ii";//$NON-NLS-1$ Line 30: public static final String DEFAULT_DATE_FORMAT = "mm/dd/yyyy";//$NON-NLS-1$ Line 31: private final DateTimePicker dateTimePicker = new DateTimePicker(); > I think Gregs point is that all this class does is implement TakesValue<Dat I wasn't sure of the reason. I was just curious. I don't mind delegation. I leave it up to Alexander :) Line 32: private String dateTimeFormat; Line 33: Line 34: public GwtBootstrapDateTimePicker() { Line 35: this(DEFAULT_DATE_TIME_FORMAT, true); -- To view, visit https://gerrit.ovirt.org/38729 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f2a9eced817d8ed040901255983e5673990f1f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Greg Sheremeta <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
