Moti Asayag has uploaded a new change for review. Change subject: engine: Declare typed variables in GetVmsByStorageDomainQueryTest ......................................................................
engine: Declare typed variables in GetVmsByStorageDomainQueryTest Change-Id: Ief2e487e2c9eb2b8ef86bcad6a3897cab402d5bc Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java 1 file changed, 4 insertions(+), 7 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/79/38779/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java index 1c548cf..b0016dd 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetVmsByStorageDomainQueryTest.java @@ -33,9 +33,8 @@ } @Test - @SuppressWarnings("unchecked") public void testExecuteQueryCommandNoDisks() { - List<VM> vmsOfDomain = new ArrayList(); + List<VM> vmsOfDomain = new ArrayList<>(); VM vm1 = mock(VM.class); VM vm2 = mock(VM.class); vmsOfDomain.add(vm1); @@ -56,9 +55,8 @@ } @Test - @SuppressWarnings("unchecked") public void testExecuteQueryCommandNoVms() { - List<VM> vmsOfDomain = new ArrayList(); + List<VM> vmsOfDomain = new ArrayList<>(); when(vmDao.getAllForStorageDomain(domainId)).thenReturn(vmsOfDomain); @@ -75,9 +73,8 @@ } @Test - @SuppressWarnings("unchecked") public void testExecuteQueryCommandSharedDisks() { - List<VM> vmsOfDomain = new ArrayList(); + List<VM> vmsOfDomain = new ArrayList<>(); VM vm1 = new VM(); vm1.setName("vm1"); VM vm2 = new VM(); @@ -93,7 +90,7 @@ List<DiskImage> diskImages = new ArrayList<>(); DiskImage d1 = mock(DiskImage.class); when(d1.isShareable()).thenReturn(true); - ArrayList<String> vmNames = new ArrayList(); + ArrayList<String> vmNames = new ArrayList<>(); vmNames.add("vm1"); vmNames.add("vm2"); when(d1.getVmNames()).thenReturn(vmNames); -- To view, visit https://gerrit.ovirt.org/38779 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ief2e487e2c9eb2b8ef86bcad6a3897cab402d5bc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
