Idan Shaby has posted comments on this change. Change subject: uicommonweb: Enabling tooltip for BaseEntityModelCheckboxEditor ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/38662/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AbstractValidatedWidgetWithLabel.java: Line 210: public void setLabel(String labelText) { Line 211: label.getElement().setInnerText(labelText); Line 212: } Line 213: Line 214: public void setHtmlLabel(SafeHtml htmlLabel) { > actually, I think 'setLabelHTML' looks better... :) Done Line 215: label.getElement().setInnerSafeHtml(htmlLabel); Line 216: } Line 217: Line 218: @Override -- To view, visit https://gerrit.ovirt.org/38662 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081b223ed16991f82b5c2ebb90aa7dd7ec3d398a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Idan Shaby <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
