Ala Hino has posted comments on this change. Change subject: core: Prevent VM migration when SCSI reservation is used ......................................................................
Patch Set 7: (2 comments) https://gerrit.ovirt.org/#/c/37664/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java: Line 248: } Line 249: } Line 250: Line 251: @Override Line 252: protected void updateMigrationModeAvailabilityBasedOnScsiReservation() { > formatter Done Line 253: boolean isUsingScsiReservation = false; Line 254: for (Disk disk : getVm().getDiskMap().values()) { Line 255: if (disk instanceof LunDisk) { Line 256: if (((LunDisk)disk).isUsingScsiReservation()) { Line 260: } Line 261: } Line 262: Line 263: if (isUsingScsiReservation) { Line 264: getModel().getMigrationMode().setSelectedItem(null); > null? Why not MigrationSupport.PINNED_TO_HOST? Good input. I considered setting the value to PINNED-TO-HOST but thought it could be misleading because the admin didn't explicitly set that. However, on a second thought, I will sett it to PINNED-TO-HOST and will have this tool tip: "VM is implicitly pinned to host because it uses SCSI reservation" Line 265: getModel().getMigrationMode().setIsChangable(false); Line 266: getModel().getMigrationMode().setChangeProhibitionReason(constants.vmUsesScsiReservation()); Line 267: } Line 268: } -- To view, visit https://gerrit.ovirt.org/37664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia38c03dae04c9dbb30c882941391b1909f5af416 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ala Hino <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Candace Sheremeta <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> Gerrit-Reviewer: Idan Shaby <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
