Eli Mesika has posted comments on this change.

Change subject: WIP: core: gluster: set iptables rules for HC ports
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/38815/2/packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql
File packaging/dbscripts/upgrade/pre_upgrade/0000_config.sql:

Line 323: -A INPUT -p tcp -m tcp --dport 139   -j ACCEPT
Line 324: -A INPUT -p tcp -m tcp --dport 445   -j ACCEPT
Line 325: 
Line 326: # Ports for gluster volume bricks (default 100 ports)
Line 327: # TODO: check if this is still valid!
What about this TODO , IMO should not be merged with this comment ....
Line 328: -A INPUT -p tcp -m tcp --dport 24009:24108 -j ACCEPT
Line 329: 
Line 330: # Ports for gluster volume bricks in Hyper Converged setup(default 
100 ports)
Line 331: -A INPUT -p tcp -m tcp --dport 49217:49316 -j ACCEPT


Line 752: # smbd
Line 753: -A INPUT -p tcp -m tcp --dport 139   -j ACCEPT
Line 754: -A INPUT -p tcp -m tcp --dport 445   -j ACCEPT
Line 755: 
Line 756: # Ports for gluster volume bricks (default 100 ports)
Same here , if not relevant anymore on the ADD section , should be applied also 
here ....
Line 757: -A INPUT -p tcp -m tcp --dport 24009:24108 -j ACCEPT
Line 758: 
Line 759: # Ports required for GlusterFS brick processes have changed in
Line 760: # glusterfs 3.4.0 from 24009 onwards to 49152 onwards.


-- 
To view, visit https://gerrit.ovirt.org/38815
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaeda3f4310d7f3be69abf47758ceae629682feb7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
Gerrit-Reviewer: Simone Tiraboschi <[email protected]>
Gerrit-Reviewer: Vijay Bellur <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to