Alon Bar-Lev has posted comments on this change.

Change subject: aaa: normalize extension name within ENGINE_EXTENSION_ENABLED_
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/37221/3/packaging/services/ovirt-engine/ovirt-engine.conf.in
File packaging/services/ovirt-engine/ovirt-engine.conf.in:

Line 236: 
Line 237: #
Line 238: # Disable extensions (override extension configuration)
Line 239: #
Line 240: # ENGINE_EXTENSION_ENABLED_<name>=false
> I know that's what normalize do, but you use this conf also in ovirt-engine
this accepts only _ and letters or digits

    private String normalizeName(String s) {
        StringBuilder ret = new StringBuilder();
        for (char c : s.toCharArray()) {
            if (c == '_' || Character.isLetterOrDigit(c)) {
                ret.append(c);
            } else {
                ret.append('_');
            }
        }
        return ret.toString();
    }


-- 
To view, visit https://gerrit.ovirt.org/37221
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a06518ff7c96ec7483b26591408cd2977636e36
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ondra Machacek <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to