Lior Vernia has posted comments on this change. Change subject: engine: Deprecate usage of network entries where possible ......................................................................
Patch Set 2: Verified+1 (1 comment) Works fine now. https://gerrit.ovirt.org/#/c/37081/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 1322: * only be extracted for bridged networks and from bridge entries (not network entries) Line 1323: **/ Line 1324: Map<String, Object> effectiveProperties = Line 1325: (bridgesReported && bridgedNetwork && bridgeProperties != null) ? bridgeProperties Line 1326: : network; > here we're assigning bridgeProperties or network to effectiveProperties. I I don't understand the problem with the naming. network is changed to networkProperties in the next patch, and then effectiveProperties holds the effective properties of either the network or the bridge (whatever needs to take effect). Any other suggestion? Line 1327: String addr = extractAddress(effectiveProperties); Line 1328: String subnet = extractSubnet(effectiveProperties); Line 1329: String gateway = (String) effectiveProperties.get(VdsProperties.GLOBAL_GATEWAY); Line 1330: -- To view, visit https://gerrit.ovirt.org/37081 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a46a277912b3a3013c379107f3cd6aa3cb52be9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
