Yedidyah Bar David has posted comments on this change. Change subject: packaging: setup: Inform the user about availability of DWH and Reports ......................................................................
Patch Set 24: (5 comments) https://gerrit.ovirt.org/#/c/38277/24/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/core/advertise_dwh.py: Line 118: ), Line 119: condition=lambda self: self.environment[oenginecons.CoreEnv.ENABLE], Line 120: ) Line 121: def _closeup(self): Line 122: if not self.environment.get( You can add all this test to the condition= above (and thus reduce the nesting level) Line 123: oenginecons.DWHCoreEnv.ENABLE Line 124: ) and not self.environment.get( Line 125: oenginecons.ReportsCoreEnv.ENABLE Line 126: ) and not self._dwhHost: Line 130: ) Line 131: Line 132: if not self.environment.get(osetupcons.DocsEnv.DOCS_LOCAL): Line 133: self.dialog.note( Line 134: text=_( no need for _() hear - you already called it above Line 135: noteText + Line 136: ' {dwhURL}\n' Line 137: ' {reportsURL}\n' Line 138: ).format( Line 150: else: Line 151: engineURI = '/' Line 152: Line 153: self.dialog.note( Line 154: text=_( also here Line 155: noteText + Line 156: ' http://{fqdn}:{httpPort}{engineURI}{dwhURL}\n' Line 157: ).format( Line 158: fqdn=self.environment[osetupcons.ConfigEnv.FQDN], Line 171: ], Line 172: ) Line 173: ) Line 174: else: Line 175: if self._dwhHost: Write to log only, above - when set Line 176: self.dialog.note( Line 177: text=_( Line 178: 'DWH detected at {host}.' Line 179: ).format( Line 179: ).format( Line 180: host=self._dwhHost Line 181: ) Line 182: ) Line 183: else: drop imo Line 184: self.dialog.note( Line 185: text=_( Line 186: 'DWH detected.' Line 187: ) -- To view, visit https://gerrit.ovirt.org/38277 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61fb88a6430eec6b6425075df0e749644654753a Gerrit-PatchSet: 24 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lev Veyde <[email protected]> Gerrit-Reviewer: Lev Veyde <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
