Michael Pasternak has posted comments on this change.
Change subject: restapi: Update Tag Makes Redundant Call
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTagResource.java
Line 39: }
Line 40:
Line 41: String existingParentId =
Line 42: getEntity(new
QueryIdResolver(VdcQueryType.GetTagByTagId, GetTagByTagIdParameters.class),
true).getparent_id()
Line 43: .toString();
please use this.get() instead
Line 44: if (isSetParent(incoming) &&
!existingParentId.equals(incoming.getParent().getTag().getId())) {
Line 45: moveTag(asGuid(incoming.getParent().getTag().getId()));
Line 46: }
Line 47:
--
To view, visit http://gerrit.ovirt.org/7818
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01ddc4f951b43a66cc44152df7ff67fb4f87f6b1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
