Tal Nisan has posted comments on this change. Change subject: core: Switched ineritance between Connect & Disconnet pool params (#846768) ......................................................................
Patch Set 1: And have a set of parameters in DisconnectParams which is not needed there in the first place? Not to mention that if in the future another parameter will be added/omitted from one of the parent classes, instead of changing it in a single class, you will then have to remember to change it in the toString() of DisconnectParams class -- To view, visit http://gerrit.ovirt.org/7808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f0b389508b7b9b30169ba9a1fdfa2effc8d74e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
