Martin Peřina has posted comments on this change. Change subject: core: Provide copy constructor for FenceAgent ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38163/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/FenceAgent.java: Line 79: } > Did you consider implementing clone() instead? Personally I hate clone() and Clonable it's very badly designed (more info can be found at page 54, Item 11: Override clone judiciously in [1]). IMO using copy constructors make the code more readable and safer. [1] http://uet.vnu.edu.vn/~chauttm/e-books/java/Effective.Java.2nd.Edition.May.2008.3000th.Release.pdf -- To view, visit https://gerrit.ovirt.org/38163 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I382e01d35af79a3600e34e9a74757c2eba831482 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
