Martin Peřina has posted comments on this change. Change subject: core: FenceVdsVDSCommandParameters code cleanup ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/38061/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceExecutor.java: Line 182: realAgent > I have a bit of an issue with the description 'real'. I realize that you bo Well, that's our terminology, because we provide fence agents mapping feature, where you can create a custom agent definition which is mapped into some supported agent. So term "real" mean, that we convert custom mapped agent into destination one and convert also necessary its parameters. So "real" term sound good for me :-) -- To view, visit https://gerrit.ovirt.org/38061 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I055276a4012180fda23bb2063c38df3bdd6ce876 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
