Muli Salem has posted comments on this change.

Change subject: engine: Validate MTU support in CDA (#854496)
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 433: NETWORK_INTERFACES_NOT_EXCLUSIVELY_USED_BY_NETWORK=Cannot ${action} 
${type}. The following Network Interfaces can have only a single VM Logical 
Network, or at most one non-VM Logical Network and/or several VLAN Logical 
Networks: ${NETWORK_INTERFACES_NOT_EXCLUSIVELY_USED_BY_NETWORK_LIST}.
Line 434: NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS=Cannot ${action} ${type}. 
The following VMs are actively using the Logical Network: 
${NETWORK_CANNOT_DETACH_NETWORK_USED_BY_VMS_LIST}. Please stop the VMs and try 
again.
Line 435: NON_VM_NETWORK_CANNOT_SUPPORT_STP=Cannot ${action} ${type}. STP can 
only be enabled on VM Networks.
Line 436: NETWORK_MTU_DIFFERENCES=Cannot ${action} ${type}. The following 
Logical Networks don't have the same MTU value: ${NETWORK_MTU_DIFFERENCES_LIST}.
Line 437: NETWORK_MTU_OVERRIDE_NOT_SUPPORTED=Cannot ${action} ${type}. 
Overriding MTU is not supported for this Data Center compatibility version.
"Data Center" ==> "Data Center's" ?

Same goes for the other files with the error message.
Line 438: CANNOT_PREIEW_CURRENT_IMAGE=The currently used VM Snapshot Image 
cannot be used in Preview command.
Line 439: CONFIG_UNKNOWN_KEY=Illegal configuration entry.\n\
Line 440:       -Please check configuration entry name.
Line 441: TAGS_SPECIFIED_TAG_CANNOT_BE_THE_PARENT_OF_ITSELF=Operation canceled, 
recursive Tag hierarchy cannot be defined.


--
To view, visit http://gerrit.ovirt.org/7813
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe07da82009fcb8d433ea6cb94d150bf2796c26
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to