Alona Kaplan has posted comments on this change. Change subject: engine: CRUD actions for HostNicVfsConfig ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/35948/16/packaging/dbscripts/upgrade/03_06_1090_add_host_nic_vfs_config_table.sql File packaging/dbscripts/upgrade/03_06_1090_add_host_nic_vfs_config_table.sql: Line 12: r > wouldn't that have to be: "are_all_networks_allowed" so it would be grammat Eli said- "prefix booleans with is_", imo, standard is more important than grammar. -- To view, visit https://gerrit.ovirt.org/35948 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I022a1d19d935832a8baae41c123322dff0ab779b Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
