Omer Frenkel has posted comments on this change. Change subject: events: VM status update ......................................................................
Patch Set 4: just to elaborate more on Michal's concerns: this change, as is, would break the vm monitoring: currently, when the engine identifies a change in vm status, it is getting stats of this vm, and runs logic to handle the new status, for example, vm moves to down, there is a process the vm is going, like cleanup, restore snapshot if needed, rerun for ha and more with this code, the monitoring will not see the change, because it will be already updated in the db... so we need to plan how we use this great events mechanism to work with current code, and not around it. -- To view, visit https://gerrit.ovirt.org/37758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fb17e714390d07b215f1251d18fca9195c38565 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
