Martin Peřina has posted comments on this change. Change subject: core: Refactor FenceVdsVDSCommand return value ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/38062/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/pm/FenceOperationResult.java: Line 15: HostPowerStatus > There's a tricky little point here. Well, here's why I named it HostPowerStatus: 1. I wasn't sure if just PowerStatus will be descriptive enough 2. The only case when the term may not be completely true is when you are asking to get power status for specific single agent (the test button you described above) for the host that has more agents. In all other cases you want to know power status of the host But if needed I can rename it to PowerStatus or any other better name :-) -- To view, visit https://gerrit.ovirt.org/38062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b3ada18bb36a376c5c19327461d2daa53eedc59 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
