Eli Mesika has posted comments on this change. Change subject: core: Replace FenceExecutor in PmHealthCheckManager ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38971/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/pm/PmHealthCheckManager.java: Line 313: }); Line 314: } Line 315: } Line 316: Line 317: protected boolean isHostPoweredOff(VDS host) { IMO same appears in ssh soft fencing , can we avoid code duplication and put this method in a place that is reachable by both this and SShSoftFencingCommand ???? Line 318: HostFenceActionExecutor executor = new HostFenceActionExecutor(host); Line 319: FenceOperationResult result = executor.fence(FenceActionType.STATUS); Line 320: return result.getStatus() == Status.SUCCESS Line 321: && result.getPowerStatus() == HostPowerStatus.OFF; -- To view, visit https://gerrit.ovirt.org/38971 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5bf7cea4e3116e7c63b9f6b118379b120c077ec9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
