Moti Asayag has uploaded a new change for review. Change subject: engine: Adding default implementation to abstract methods ......................................................................
engine: Adding default implementation to abstract methods Commit 35c2e7ceb5109c9349e3699c3f53414cbe0b4c4e broke the build by introducing an abstract method which isn't implmemented by other non-abstract classes. Change-Id: I5a8478062b5f9ad545ad8bdf87d01fa05b6686f0 Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/65/7865/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java index 63a5571..66658ed 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VDSCommandBase.java @@ -5,9 +5,9 @@ import org.ovirt.engine.core.common.errors.VdcBllErrors; import org.ovirt.engine.core.common.vdscommands.VDSParametersBase; import org.ovirt.engine.core.common.vdscommands.VDSReturnValue; +import org.ovirt.engine.core.dal.VdcCommandBase; import org.ovirt.engine.core.utils.log.Log; import org.ovirt.engine.core.utils.log.LogFactory; -import org.ovirt.engine.core.dal.VdcCommandBase; import org.ovirt.engine.core.vdsbroker.irsbroker.IRSErrorException; import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSExceptionBase; import org.ovirt.engine.core.vdsbroker.vdsbroker.VDSNetworkException; @@ -114,7 +114,9 @@ log.errorFormat("Command {0} execution failed. Exception: {1}", getCommandName(), ExceptionUtils.getMessage(ex)); } - protected abstract String getAdditionalInformation(); + protected String getAdditionalInformation() { + return ""; + } protected abstract void ExecuteVDSCommand(); -- To view, visit http://gerrit.ovirt.org/7865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a8478062b5f9ad545ad8bdf87d01fa05b6686f0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
