Maor Lipchuk has posted comments on this change. Change subject: core: introduce CinderBroker ......................................................................
Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/39016/4//COMMIT_MSG Commit Message: Line 8: Line 9: Introducing CinderBroker class which handles all invocations Line 10: of Cinder sdk actions (e.g. createVolume/deleteVolume/etc). Line 11: The CinderBroker adds VdcBllErrors.CINDER_ERROR to executeFailedMessages Line 12: in case of an OpenStackResponseException. Please elaborate why we chose to use the vdsmErrors and also that the issue why we can't translate Cinder errors (since those are simply codes and no explicit messages) Line 13: Line 14: Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef Line 15: Bug-Url: https://bugzilla.redhat.com/1185826 -- To view, visit https://gerrit.ovirt.org/39016 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If71305412188be95dc88bc0d8646958a3d3e6aef Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
