Daniel Erez has posted comments on this change. Change subject: core: CinderDisksValidator - validateCinderDiskLimits ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/39023/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/storage/CinderDisksValidator.java: Line 47: public ValidationResult call() { Line 48: for (CinderDisk disk : cinderDisks) { Line 49: OpenStackVolumeProviderProxy proxy = diskProxyMap.get(disk.getId()); Line 50: Limits limits = proxy.getLimits(); Line 51: if (limits.getAbsolute().getTotalVolumesUsed() >= limits.getAbsolute().getMaxTotalVolumes()) { > What if we will add several disks, should we need to summarize them one aft Done Line 52: return new ValidationResult(VdcBllMessages.CANNOT_ADD_CINDER_DISK_VOLUME_LIMIT_EXCEEDED, Line 53: String.format("$maxTotalVolumes %d", limits.getAbsolute().getMaxTotalVolumes()), Line 54: String.format("$diskAlias %s", disk.getDiskAlias())); Line 55: } -- To view, visit https://gerrit.ovirt.org/39023 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I532cbb800a54f9742d11c361789ba3bf693d01ad Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
