Greg Sheremeta has uploaded a new change for review. Change subject: userportal, webadmin: cleanup constants in PermissionListModelTable ......................................................................
userportal, webadmin: cleanup constants in PermissionListModelTable No need to pass around CommonApplicationConstants in PermissionListModelTable. Removed all the parameters. Change-Id: I3b2bfb86aa297142c28e17beca2c24c31a1f300c Signed-off-by: Greg Sheremeta <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java 1 file changed, 19 insertions(+), 18 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/07/39107/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java index d8a7ebe..0a01350 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/permissions/PermissionListModelTable.java @@ -1,6 +1,7 @@ package org.ovirt.engine.ui.common.widget.uicommon.permissions; -import com.google.gwt.event.shared.EventBus; +import java.util.Date; + import org.ovirt.engine.core.common.businessentities.Permission; import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.gin.AssetProvider; @@ -15,7 +16,7 @@ import org.ovirt.engine.ui.uicommonweb.UICommand; import org.ovirt.engine.ui.uicommonweb.models.configure.PermissionListModel; -import java.util.Date; +import com.google.gwt.event.shared.EventBus; public class PermissionListModelTable<P extends PermissionListModel<?>> extends AbstractModelBoundTableWidget<Permission, P> { @@ -31,22 +32,22 @@ public void initTable() { getTable().enableColumnResizing(); //add columns - addTypeColumn(constants); - addUserColumn(constants); - addAuthzColumn(constants); - addNameSpaceColumn(constants); - addRoleColumn(constants); - addCreationDateColum(constants); + addTypeColumn(); + addUserColumn(); + addAuthzColumn(); + addNameSpaceColumn(); + addRoleColumn(); + addCreationDateColum(); // add buttons - addAddPermissionsButton(constants); - addRemovePermissionsButton(constants); + addAddPermissionsButton(); + addRemovePermissionsButton(); } - private void addTypeColumn(CommonApplicationConstants constants) { + private void addTypeColumn() { getTable().addColumn(new PermissionTypeColumn(), constants.empty(), "30px"); //$NON-NLS-1$ } - private void addUserColumn(CommonApplicationConstants constants) { + private void addUserColumn() { AbstractTextColumn<Permission> userColumn = new AbstractTextColumn<Permission>() { @Override public String getValue(Permission object) { @@ -57,7 +58,7 @@ getTable().addColumn(userColumn, constants.userPermission(), "300px"); //$NON-NLS-1$ } - private void addAuthzColumn(CommonApplicationConstants constants) { + private void addAuthzColumn() { AbstractTextColumn<Permission> authzColumn = new AbstractTextColumn<Permission>() { @Override public String getValue(Permission object) { @@ -68,7 +69,7 @@ getTable().addColumn(authzColumn, constants.authz(), "150px"); //$NON-NLS-1$ } - private void addNameSpaceColumn(CommonApplicationConstants constants) { + private void addNameSpaceColumn() { AbstractTextColumn<Permission> namespaceColumn = new AbstractTextColumn<Permission>() { @Override public String getValue(Permission object) { @@ -79,7 +80,7 @@ getTable().addColumn(namespaceColumn, constants.namespace(), "150px"); //$NON-NLS-1$ } - private void addRoleColumn(CommonApplicationConstants constants) { + private void addRoleColumn() { AbstractTextColumn<Permission> roleColumn = new AbstractTextColumn<Permission>() { @Override public String getValue(Permission object) { @@ -90,7 +91,7 @@ getTable().addColumn(roleColumn, constants.rolePermission(), "300px"); //$NON-NLS-1$ } - private void addCreationDateColum(CommonApplicationConstants constants) { + private void addCreationDateColum() { AbstractTextColumn<Permission> creationDateColumn = new AbstractRenderedTextColumn<Permission, Date>(new FullDateTimeRenderer()) { @Override public Date getRawValue(Permission object) { @@ -101,7 +102,7 @@ creationDateColumn.makeSortable(); } - private void addAddPermissionsButton(final CommonApplicationConstants constants) { + private void addAddPermissionsButton( ) { getTable().addActionButton(new UiCommandButtonDefinition<Permission>(getEventBus(), constants.addPermission()) { @Override protected UICommand resolveCommand() { @@ -110,7 +111,7 @@ }); } - private void addRemovePermissionsButton(final CommonApplicationConstants constants) { + private void addRemovePermissionsButton( ) { getTable().addActionButton(new UiCommandButtonDefinition<Permission>(getEventBus(), constants.removePermission()) { @Override protected UICommand resolveCommand() { -- To view, visit https://gerrit.ovirt.org/39107 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b2bfb86aa297142c28e17beca2c24c31a1f300c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
