Moti Asayag has uploaded a new change for review. Change subject: engine: Use hasItem matcher to verify nic exists ......................................................................
engine: Use hasItem matcher to verify nic exists Change-Id: I1438626bbac102a55cab9808daa3b5465f7ecebc Signed-off-by: Moti Asayag <[email protected]> --- M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/39124/1 diff --git a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java index 267823d..7c71feb 100644 --- a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java +++ b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java @@ -1,7 +1,9 @@ package org.ovirt.engine.core.vdsbroker.vdsbroker; +import static org.hamcrest.CoreMatchers.hasItem; import static org.junit.Assert.assertEquals; import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertThat; import static org.junit.Assert.assertTrue; import static org.mockito.Matchers.any; import static org.mockito.Mockito.mock; @@ -255,8 +257,8 @@ List<String> nicsInStruct = (List<String>) bondMap.get(SetupNetworksVDSCommand.SLAVES); for (VdsNetworkInterface slave : slaves) { - assertTrue("Slave " + slave.getName() + " should've been sent but wasn't.", - nicsInStruct.contains(slave.getName())); + assertThat("Slave " + slave.getName() + " should've been sent but wasn't.", + nicsInStruct, hasItem(slave.getName())); } return bondMap; -- To view, visit https://gerrit.ovirt.org/39124 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1438626bbac102a55cab9808daa3b5465f7ecebc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
