Francesco Romani has posted comments on this change. Change subject: guest manager: single-thread monitoring ......................................................................
Patch Set 5: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/37826/5/mom/GuestManager.py File mom/GuestManager.py: Line 130: for id, guest in self.guests.items(): Line 131: if guest.thread is None: Line 132: # no thread to babysit Line 133: continue Line 134: # Check if the thread has died 'has died'? Line 135: if not guest.thread.is_alive(): Line 136: del self.guests[id] Line 137: # Check if the domain has ended according to hypervisor interface Line 138: elif id not in domain_list: Line 167: Line 168: def _collect_from_guest_monitors(self): Line 169: with self.guests_sem: Line 170: for uuid, guest in self.guests.items(): Line 171: if guest.monitor.isReady(): this is wrong and should be avoided. Line 172: guest.monitor.collect() Line 173: Line 174: def _register_guest(self, uuid, guest): Line 175: if uuid not in self.guests: -- To view, visit https://gerrit.ovirt.org/37826 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I96b96fef0c0c42fd45b76754da9c629865ab1954 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
