Maor Lipchuk has posted comments on this change.
Change subject: core : create template from VM with no snappable disks (#841534)
......................................................................
Patch Set 10: (1 inline comment)
What about the GUI part?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
Line 258: boolean doesVmTemplateContainImages =
!getParameters().getImages().isEmpty();
Line 259: if (doesVmTemplateContainImages) {
Line 260: MoveOrCopyAllImageGroups(getVmTemplateId(),
getParameters().getImages());
Line 261: }
Line 262:
Please remove empty lines
Line 263: VmDeviceUtils.addImportedDevices(getVmTemplate(),
getParameters().isImportAsNewEntity());
Line 264:
Line 265: if (!doesVmTemplateContainImages) {
Line 266: EndMoveOrCopyCommand();
--
To view, visit http://gerrit.ovirt.org/6593
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie825ea39fee6d6d5c86f9c82f3008fa314392ed2
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
